Re: [PATCH] If no devices were found do not SIGSEGV (#567939)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I do not insist, I just said both ways are ugly. And the systematic one is less readable than both unfortunately. Writing the for in a block may be the best way now that I think about it... (the one nobody of us considered here..)

Martin

----- "Hans de Goede" <hdegoede@xxxxxxxxxx> wrote:

> Hi,
> 
> On 03/05/2010 11:13 AM, Martin Sivak wrote:
> > Hi,
> >
> > Well.. this is ugly too :) And does not reflect the logic.. of
> course compiler would probably optimize it into my form anyways :)
> >
> 
> If you insist on doing things your way, please do it properly and but
> the if and for on a separate line and indent the for block.
> 
> Regards,
> 
> Hans
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux