Thanks for review,
Steffen Maier wrote:
On 03/01/2010 05:34 PM, Radek Vykydal wrote:
Prevents sigsegv on x86_64.
I would think this bug exists cross-platform, i.e. not just x86_64.
After all it was originally reported for s390x.
You are right.
This looks good for fixing the specific use case of specifying
repo=nfsiso:... without stage2=...
However, I fear ld->method will remain -1 or the like and ld->stage2Data
will remain without allocated memory whenever the user has a typo in his
repo method. Will loader still segfault when the user accidently
specified repo=vtp://... ? IMHO, anaconda should not break down on
invalid user input.
True, I'd rather handle it in another patch (probably better
with appropriate new bug open?) that I am going to send to
devel list.
Radek
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
