Re: [PATCH 2/4] Add 5 second ping delay for gateway and dns test on s390x (#536815).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks good, thanks.

It now waits a maximum of 5 seconds for one echo reply to return
successfully, i.e. after the first reply within 5 seconds it'll
terminate successfully.

On 01/27/2010 06:46 PM, David Cantrell wrote:
> ---
>  loader/linuxrc.s390 |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/loader/linuxrc.s390 b/loader/linuxrc.s390
> index 9d04b9d..c862a84 100644
> --- a/loader/linuxrc.s390
> +++ b/loader/linuxrc.s390
> @@ -2036,7 +2036,7 @@ function configure_ipv4_gateway() {
>          # (virtual) CTC(/A) seems to need some time to get functional
>          local i=1
>          while : ; do
> -            ping -c 1 $GATEWAY >& /dev/null && break
> +            ping -c 1 -w 5 $GATEWAY >& /dev/null && break
>              i=$((i+1))
>              if [ "$i" -gt 3 ]; then
>                  echo $"Could not reach gateway $GATEWAY within timeout"
> @@ -2044,7 +2044,7 @@ function configure_ipv4_gateway() {
>              fi
>          done
>      else
> -        if ! ping -c 1 $GATEWAY >& /dev/null; then
> +        if ! ping -c 1 -w 5 $GATEWAY >& /dev/null; then
>              echo $"Could not reach your default gateway $GATEWAY"
>              return 1
>          fi
> @@ -2283,7 +2283,7 @@ function handle_dns() {
>              # reachable by ping, so it would make sense to use nslookup.
>              # However, nslookup fails with "Resolver Error 0 (no error)"
>              # at this stage of the setup progress => not useful
> -            if ! ping -c 1 $dnsitem >& /dev/null; then
> +            if ! ping -c 1 -w 5 $dnsitem >& /dev/null; then
>                  echo $"Could not ping DNS server: $dnsitem"
>  #                if nslookup $dnsitem $dnsitem >& /dev/null; then
>  #                    echo $" but could resolve DNS server with itself: $dnsitem"

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux