Hi,
On 01/27/2010 04:42 PM, Chris Lumens wrote:
Replace all usage of the isys C EDD code with the new storage
python EDD code. Note that this moves the sorting of partition.req_disks
from devices.py to paritioning.py, because sorting now needs access
to the storage object, this also has the added advantange that now we
always allocatePartitions in sorted drive order, even in interactive mode.
This patch makes me wonder if Storage really is the right place for
compareDisks. It doesn't look like compareDisks does anything that
needs knowledge of the storage module, and leads to some pretty awkward
paths to access it.
One of the main reasons to rewrite the EDD code is python is to have access
to the devicetree topology and thus avoid probing both BIOS RAID members
and the set and then complain about duplicate mbr signatures.
This means that the edd dict needs to get populated after the devicetree
has been populated, and populating the dict needs access to storage.partitioned
so storage itself seems like a logical place to do the populating from, which
in turn makes it a good place to store the dict, and thus to have
the compareDisks method.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
