Re: [PATCH] DMRaidArrayDevice don't pass major/minor to DMDevice.__init__ (#558440)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack.

On Mon, 2010-01-25 at 20:02 +0100, Hans de Goede wrote:
> The changes for the filtering UI and the whole disk formatting seem to have
> broken dmraid BIOS RAID support, the first traceback I hit while testing is
> due to DMRaidArrayDevice.__init__ now calling DMDevice.__init__ (was
> DiskDevice.__init__), and DMDevice.__init__ does not accept major and minor
> arguments.
> ---
>  storage/devices.py |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index 9df23f0..d5ca22b 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -2847,8 +2847,7 @@ class DMRaidArrayDevice(DMDevice):
>      _isDisk = True
>  
>      def __init__(self, name, raidSet=None, format=None,
> -                 size=None, major=None, minor=None, parents=None,
> -                 sysfsPath=''):
> +                 size=None, parents=None, sysfsPath=''):
>          """ Create a DMRaidArrayDevice instance.
>  
>              Arguments:
> @@ -2868,8 +2867,7 @@ class DMRaidArrayDevice(DMDevice):
>                  if not parent.format or parent.format.type != "dmraidmember":
>                      raise ValueError("parent devices must contain dmraidmember format")
>          DMDevice.__init__(self, name, format=format, size=size,
> -                          major=major, minor=minor, parents=parents,
> -                          sysfsPath=sysfsPath, exists=True)
> +                          parents=parents, sysfsPath=sysfsPath, exists=True)
>  
>          self.formatClass = get_device_format_class("dmraidmember")
>          if not self.formatClass:


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux