Hi, On 01/25/2010 03:36 PM, Chris Lumens wrote:
diff --git a/iw/filter_gui.py b/iw/filter_gui.py index 3b6f573..a0f6704 100644 --- a/iw/filter_gui.py +++ b/iw/filter_gui.py @@ -586,6 +586,10 @@ class FilterWindow(InstallWindow): except (_ped.IOException, _ped.DeviceException): continue d["XXX_SIZE"] = int(partedDevice.getSize()) + # cciss controllers, without any sets defined, show up as a 0 size + # blockdev, ignore these + if d["XXX_SIZE"] == 0: + continue # This isn't so great, but for iSCSI devices the path contains a lot # of useful identifiying info that should be displayed.Should these perhaps be excluded at a lower level, like perhaps in __is_blacklisted_blockdev or udev_enumerate_block_devices? This feels like too much of a hack to me.
That would be a good idea, yes. But that would require figuring out something in udev to tell from this is the case (or doing some sysfs grobing in one of those 2 functions. Either of which needs access to such a machine to actually see what is there to trigger this blacklisting on. The above patch is the tried and proven way of handling this from mediaPresent in devices.py (and yes I know you object to the naming of mediaPresent and I agree). When doing the usb reader fix (which is also being handled through mediaPresent in devices.py), it occured to me (some time later) that filter ui would also need a fix for the bizarro 0 bytes large cciss block node case. IOW I agree, but I think that for now this is the best way of dealing with this, and then later we can make it prettier. Regards, Hans _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
