Re: [PATCH 7/8] Remove setting of _isDisk and _partitionable from iscsi and fcoe disk code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-01-22 at 10:24 +0100, Hans de Goede wrote:
> They already enherit the correct values from DiskDevice, and setting
> them explictly is inconsisten with ZFCPDevice and DASDDevice which do not
> do this.

Sure, ack.

> ---
>  storage/devices.py |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index 52e0466..42b0fdf 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -3288,8 +3288,6 @@ class iScsiDiskDevice(DiskDevice, NetworkStorageDevice):
>      """ An iSCSI disk. """
>      _type = "iscsi"
>      _packages = ["iscsi-initiator-utils", "dracut-network"]
> -    _partitionable = True
> -    _isDisk = True
>  
>      def __init__(self, device, **kwargs):
>          self.node = kwargs.pop("node")
> @@ -3322,8 +3320,6 @@ class FcoeDiskDevice(DiskDevice, NetworkStorageDevice):
>      """ An FCoE disk. """
>      _type = "fcoe"
>      _packages = ["fcoe-utils", "dracut-network"]
> -    _partitionable = True
> -    _isDisk = True
>  
>      def __init__(self, device, **kwargs):
>          self.nic = kwargs.pop("nic")


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux