Hi, On 01/22/2010 04:35 PM, Hans de Goede wrote:
> >>OEM's routinely ship systems with BIOS RAID enabled, so we should support > >>these in basic mode to. > > > >I really dislike this - you're redefining what "basic" means, basically > >saying "it doesn't matter whether you chose basic or not, you're still > >getting RAID devices to look at." > > Erm no I'm redefining what simple means, note that there are no tabs in simple mode > so the word "Basic" is not used. You know what I meant. Having written this screen, I am aware of where there are and are not tabs. What you see on the simple screen is the Basic tab from the advanced screen. > Also quoting from the screen where one can choose simple or complex storage: > > self.buttonGroup.addEntry("simple", _("Basic Storage Devices"), > descr=_("Installs or upgrades to typical types " > "of storage devices. If you're not sure " > "which option is right for you, this is " > "probably it.")) > self.buttonGroup.addEntry("complex", _("Specialized Storage Devices"), > descr=_("Installs or upgrades to devices such as " > "Storage Area Networks (SANs) or mainframe > "attached disks (DASD), usually in an " > "enterprise environment")) > > Notice that simple is for "typical types of storage", and BIOS RAID is > quit common, iow typical. It surely is not: > "Storage Area Networks (SANs) or mainframe attached disks (DASD)" Then perhaps the text there needs to be changed. You did not address my biggest complaint, which is that this patch will cause biosraid devices to appear in one place on the simple screen and a completely different place on the advanced screen. And, you know people are going to go back and forth between the two to see what exciting feature they are missing.
The way I see this is: In the simple screen people get a single list (no tabs), and in the advanced screen people get the disks divided over multiple tabs, so naturally some of them may be on a different tab. I must say though I wonder (a bit late I guess, but this is the first time I'm actually playing around with the new code) what the use is of the simple screen is at all. Filtering was added for the big iron case, why not "simply" skip it when doing simple configuration and leave exclusiveDisks empty (thus showing all disks later as we did before). This would also reduce the number of screens shown in a simple install, which I think would be a good thing. The new code replaces a single screen in the old code with 4 new screens. Regards, Hans _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list