Re: [PATCH 5/6] Make multipath support use device-mapper-multipath to setup mpaths.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/20/2010 07:46 PM, David Lehman wrote:
> On Wed, 2010-01-20 at 19:03 -0500, Peter Jones wrote:
>> Use device-mapper-multipath's "multipath" tool to find and set up
>> multipath devices.
>> ---
>>  storage/devicelibs/mpath.py |   91 +++++++++++++++++++++++++++++--------------
>>  storage/devices.py          |   74 +++++++++++++++++++++++++++++------
>>  2 files changed, 122 insertions(+), 43 deletions(-)
>>
>> diff --git a/storage/devices.py b/storage/devices.py
>> index 237fc75..c56106f 100644
>> --- a/storage/devices.py
>> +++ b/storage/devices.py
>> @@ -3026,21 +3024,71 @@ class MultipathDevice(DMDevice):
>>          else:
>>              self.parents.append(parent)
>>  
>> -    def setup(self, intf=None):
>> -        if self.status:
>> -            self.teardown()
>> -        self._isUp = True
>> -        parents = []
>> -        for p in self.parents:
>> -            parents.append(p.path)
>> -        self._pyBlockMultiPath = block.device.MultiPath(*parents)
>> +    def setupPartitions(self):
>> +        log_method_call(self, name=self.name, kids=self.kids)
>> +        rc = iutil.execWithRedirect("kpartx",
>> +                                ["-a", "-p", "p", "/dev/mapper/%s" % self.name],
>> +                                stdout = "/dev/tty5",
>> +                                stderr = "/dev/tty5")
>> +        if rc:
>> +            raise MPathError("multipath partition activation failed for '%s'" %
>> +                            self.name)
>> +        udev_settle()
>> +
>> +    def makeDMNodes(self):
>> +        log_method_call(self, name=self.name, kids=self.kids)
>> +        rc = iutil.execWithRedirect("dmsetup", ["mknodes"],
>> +                                stdout = "/dev/tty5",
>> +                                stderr = "/dev/tty5")
> 
> Does anything call this method?

Nope, it's vestigial.  Gone in my tree.

I'm still looking at Hans's comments to the rest here.

-- 
        Peter

What we need is either less corruption, or more chances to
participate in it.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux