Re: [PATCH] Add mpath device to selection instead of its constituents.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Looks good to me, but you may want to pass this past clumens.

Regards,

Hans


On 01/21/2010 12:29 AM, Peter Jones wrote:
If we've got an mpath device in FilterWindow, it should be added to the
selection, not the constituent devices for each path.
---
  iw/filter_gui.py |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/iw/filter_gui.py b/iw/filter_gui.py
index 171b46f..77052df 100644
--- a/iw/filter_gui.py
+++ b/iw/filter_gui.py
@@ -367,10 +367,10 @@ class FilterWindow(InstallWindow):
          # are in the list.
          selected = set()
          for dev in self.pages[0].ds.getSelected():
-            for path in dev[PATHS_COL].split():
-                selected.add(path)
-
-            selected.add(udev_device_get_name(dev[OBJECT_COL]))
+            if udev_device_is_multipath_member(dev[OBJECT_COL]):
+                selected.add(udev_device_get_multipath_name(dev[OBJECT_COL]))
+            else:
+                selected.add(udev_device_get_name(dev[OBJECT_COL]))

          if len(selected) == 0:
              self.anaconda.intf.messageWindow(_("Error"),

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux