Re: [PATCH 18/19] Add mpath device to selection instead of its constituents.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is absolutely the sort of thing we need to be doing here, and we're
going to need to do the same sort of checking for biosraid, too.

> diff --git a/iw/filter_gui.py b/iw/filter_gui.py
> index 9b43b55..bac109b 100644
> --- a/iw/filter_gui.py
> +++ b/iw/filter_gui.py
> @@ -364,10 +364,13 @@ class FilterWindow(InstallWindow):
>          # are in the list.
>          selected = set()
>          for dev in self.pages[0].ds.getSelected():
> -            for path in dev[PATHS_COL].split():
> -                selected.add(path)
> +            if udev_device_is_multipath_member(dev[OBJECT_COL]):
> +                selected.add(udev_device_get_multipath_name(dev[OBJECT_COL]))
> +            else:
> +                for path in dev[PATHS_COL].split():
> +                    selected.add(path)

You shouldn't need these two lines anymore, since the only time we stick
anything into PATHS_COL is for mpath devices and you've already taken
care of that case.

I don't think you need to iterate over dev[PATHS_COL] like this anymore,
since the only time we stick anything into PATHS_COL is for mpath
devices and you've already taken care of that case.

>  
> -            selected.add(udev_device_get_name(dev[OBJECT_COL]))
> +                selected.add(udev_device_get_name(dev[OBJECT_COL]))
>  
>          if len(selected) == 0:
>              self.anaconda.intf.messageWindow(_("Error"),

Yeah, this should be sufficient.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux