Re: [PATCH 2/2] Remove unnecessary free from the rpmextract error handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack.

On 01/19/2010 04:12 PM, Martin Sivak wrote:
libarchive lacks proper documentation of its memory management, but
it seems that it takes care of freeing the memory itself. So remove the
bogus free from our code.
---
  loader/rpmextract.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/loader/rpmextract.c b/loader/rpmextract.c
index 64d5d7d..90af54c 100644
--- a/loader/rpmextract.c
+++ b/loader/rpmextract.c
@@ -282,7 +282,6 @@ int explodeRPM(const char *source,
              FILE *fdout = fopen(filename+offset, "w");

              if (fdout==NULL){
-                free((void*)filename);
                  rc = 33;
                  break;
              }

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux