> But this is first time I see some of the codestyle rules. Anaconda has > lot of codestyles in it's codebase and nobody ever told us which is > the correct one. Indentation was my mistake, because I'm used to > different setup and restored my old .vimrc. Yeah we've never really enforced any kind of style rules before, and it's not just this patch set that's the cause of starting to enforce them now. anaconda has been a mishmash of everyone's style for a long time and it really shows. For now I'm interested in people just going along with whatever's already in the files you're editing. Eventually, we really do need to suck it up and convert everything to one consistent style that no one will like. > Using glib for string handling is the same situation.. you have to > start talking about this stuff _before_ we post patches or document it > somewhere. All the rewrites delay testing a lot... Of course, it's hard to know what to talk about when we can't see things in progress. The glib stuff is new and we haven't really made a big push to get everything using it, but David did have some patches a little while back to start converting loader. We're probably not like to wholesale convert loader, but making sure new code uses glib where appropriate is good. We're linking with this stuff already. We might as well use it. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
