Chris Lumens wrote:
diff --git a/isys/isys.py b/isys/isys.py index 338ca26..d059db6 100755 --- a/isys/isys.py +++ b/isys/isys.py @@ -120,10 +120,11 @@ def unlosetup(device): # @param remount Are we mounting an already mounted filesystem? # @return The return value from the mount system call. def mount(device, location, fstype = "ext2", readOnly = False, - bindMount = False, remount = False, options = "defaults"): + bindMount = False, remount = False, options = None): flags = None location = os.path.normpath(location) - opts = string.split(options) + options = options or "defaults" + opts = options.split(",")# We don't need to create device nodes for devices that start with '/'# (like '/usbdevfs') and also some special fake devices like 'proc'.I think this is a little confusing, and might better be written as: if not options: opts = "defaults" else: opts = options.split(",")
I agree it is more readable. I'll use it.
I also note that this changes what options is split on from whitespace to comma. Do we pass comma-delimited options throughout anaconda?
When we pas multiple options, they are comma-delimited - see isys.mount call in storage/formats/fs.py and options property of FS class. Radek _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
