On 11/10/2009 02:01 PM, Jeffrey Bastian wrote:
> On 11/10/2009 12:49 PM, Peter Jones wrote:
>>> I was trying to follow the style set by the sleeping loop in
>>> kickstartFromFloppy() in kickstart.c, so if this is converted into a for
>>> loop, then all 3 while loops should probably be converted.
>>> 1. kickstartFromFloppy() in kickstart.c
>>
>> This function hasn't existed since 2007, and didn't have a loop like
>> you're describing then.
>
> It does in the RHEL-5 branch. I just updated to anaconda-11.1.2.196 to
> verify this and it's still there: see lines 246-254.
Fair enough, but this is one of just many examples where changes really need
to be done in the development branch *first* and then backported to the
RHEL 5 branch, or else we're just going to have the same bugs again in RHEL 6.
>>> 2. kickstartFromCD() in cdinstall.c
>>
>> This has no such loop.
>>
>>> 3. getFileFromBlockDevice() in method.c
>>
>> This also has no such loop...
>
> These loops are added by the patch being discussed.
Indeed; I'd read your message as saying you were reading all three of these
things as examples. Sorry about that.
--
Peter
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
