-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thu, 1 Oct 2009, Jeremy Katz wrote:
On Thu, Oct 1, 2009 at 12:48 AM, David Cantrell <dcantrell@xxxxxxxxxx> wrote:
This patch modifies the reported format strings to use named parameters
per the warning message. We were already using these style format
strings in users.py and possibly other files. Basically when there is
more than one parameter in the format string, we should use a hash table
with named parameters.
At one point, msgcheck wasn't properly making sure that the parameters
used in the translated versions of the strings matched those from the
original. If that's still the case, it raises the possibility of a
lot more tracebacks from translator typos which would be good to avoid
as there's no way we'll get 100% testing coverage of every string hit
in every language.
If not, then I'm all for it, although it does complicate things a little bit
I'm not sure if msgfmt does anything to verify that now, but the translators
would get the strings from the anaconda.pot file anyway.
I'd like to give the translators more flexibility for reorganizing the
translated string, since some translations could benefit from that. If it's
too much of a problem and we're in traceback city, we can just revert this.
- --
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkrFDOAACgkQ5hsjjIy1VkmPCgCdGemnrU7y/PLfDgdTneFB9muj
tAkAn0N9O+aG77RIyTr8NJcLpbOvYg0M
=/2DS
-----END PGP SIGNATURE-----
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
