On Wed, Sep 30, 2009 at 03:30:50PM -0400, Chris Lumens wrote: > > I also added 3 new videos showing the relevant features: > > http://jgranado.fedorapeople.org/anaconda/ui/videos/lv_create_workflow > > http://jgranado.fedorapeople.org/anaconda/ui/videos/edit_delete_buttons > > http://jgranado.fedorapeople.org/anaconda/ui/videos/message_in_canvas > > Things I noticed: > > - On the "Create..." dialog, the drop down next to the radio button for > creating an LV should be disabled unless the radio button is checked. Your probably right.... :). I would have to create a call back for when the radio button is modified and .... But its probably worth it. > > - I think better wording for that same radio button label would be > "LVM Logical Volume on " and then the drop down. I think it makes the > drop down flow better from the wording. I prefer to leave the wording on that label as is, and change the wording on the label beneath it. To say something like "Opens a LVM create window on the selected Volume Group. Two more things: 1. I would probably want to change the wording on all the 'little' labels from "Goes to a window..." to "Opens a window..." or something better than what we have. Suggestions appreciated. 2. About referring to LVM stuff. This is what I suggest: When we refer to LVM (VGs, PVs and LVs) in the UI, code, documentation we should be able to use two types of format. The long one and the short one. General rules: 1. If the context* does not specify that we are speaking about LVM we should use "LVM" to clarify. I think we should never use "Logical Volume Manager". The short one: 1. Use the two letter representation of the LVM types, the letters must be capitalized: LV -> Logical Volume PV -> Physical Volume VG -> Volume Group. 2. If one has to use the plural, append a lower case 's': LVs -> Logical Volumes PVs -> Physical Volumes VGs -> Volume Groups 3. If one needs extra context, one should prepend LVM: LVM LV -> LVM Logical Volume LVM PV -> LVM Physical Volume LVM VG -> LVM Volume Group The long one: 1. Use the 'real' name for the LVM types: logical volume physical volume volume group 2. If needed, "LVM" can be prepended: LVM logical volume LVM physical volume LVM volume group. > > - The Edit VG dialog pops up behind the Make LV dialog. Is this > intentional? I think it's kind of weird. I would change this but after we push these changes. Its not intentional, but its unavoidable for now. Since I am using the volume group edit class, which directly relates the logical volume edit with the volume group edit, its pops the volume group screen in the back. Think of this as a stepping stone for changing the logical volume edit class. When that class is refactored, we can take the logical volume editing logic out of it and put it somewhere else (where it can be used individually) > > - The "sda (/dev/sda)" label on the tree view should probably contain > more useful information in the parens, like model or size or > something. I'd would not change this. Well, The size is already present in two places. Its in the next column and its in the graph view. Additionally, think of bios raid, where the given information is not so trivial. Example: isw_asdfase_Volume0 (/dev/mapper/isw_asdfase_Volume0) Moreover we can start doing this with LVM (just thinking out loud) > > - What dialog does clicking Edit when you have an LV highlighted take > you to? To the LV editing one. In general you have three ways of activating an edit dialog: 1. Double click on the bar view slice 2. Double click on the tree view row 3. Select device through bar view or tree view and hit 'edit' > > I don't consider any of these big enough to delay you merging these > patches onto head, by the way. Yep, they are pretty small and, IMO, needed. > > > 2. I removed the "Hide" thingy. > > Die, die, die! > > > 3. Created the 'create lv' button. With this new button one can create > > an LV from the VG screen or from the 'create' screen. > > > > 4. Modified the 'edit' and 'delete' buttons to activate only when they > > are relevant. > > Great! > > > 5. There is now a message that reads 'Please Select A Device' when no > > devices are selected. > > This is a little unusual, but I think it's probably okay, and I'm > willing to let it stay and see what everyone else thinks. I actually really like this :). And It was totally NOT my idea. I was looking at the Haiku installer and saw that they had something similar. Its really better than having nothing displayed. And it tells the user that he/she is in some state that requires further action. -- Joel Andres Granados Brno, Czech Republic, Red Hat.
Attachment:
pgpkKVmjbbjis.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
