Hi,
On 09/30/2009 12:42 AM, David Lehman wrote:
On Tue, 2009-09-29 at 20:08 +0200, Hans de Goede wrote:
On 09/29/2009 06:10 PM, David Lehman wrote:
--- a/platform.py
+++ b/platform.py
@@ -330,12 +330,13 @@ class IPSeriesPPC(PPC):
if not bootPart:
return errors
- if bootPart.geometry.end * bootPart.geometry.device.sectorSize / (1024.0 * 1024)> 4096:
- errors.append(_("The boot partition must be within the first 4MB of the disk."))
-
# All of the above just checks the PPC PReP boot partitions. We still
# need to make sure that whatever /boot is on also meets these criteria.
if req == self.bootDevice():
+ # However, this check only applies to prepboot.
+ if bootPart.geometry.end * bootPart.geometry.device.sectorSize / (1024.0 * 1024)> 4096:
+ errors.append(_("The boot partition must be within the first 4MB of the disk."))
+
Am I crazy or is this test actually checking that the end is not beyond
4096MB instead of 4MB?
Erm,
sector_size (unit bytes/sector) * geometry (unit sectors) = size (unit bytes)
size (unit bytes) / 1048576 (1 Megi no unit) = size (unit Megi bytes)
Exactly -- if we want 4MB, why are we comparing the size in MB to the
number 4096?
/me removes egg from face.
Good point, so maybe we want it to be below 4 GB ? Or maybe the code indeed is broken.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
