On Thu, Sep 17, 2009 at 03:24:12PM -1000, David Cantrell wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Wed, 16 Sep 2009, Joel Granados wrote: > >> The videos can be found at: >> http://jgranado.fedorapeople.org/anaconda/ui/videos/ >> >> Review greatly appreciated. > > Video reviews/comments for now, I plan on reading through the patches after > this. > > All in all I think the UI improvements are very nice. The workflow makes more > sense in a lot of areas. That said, I do have some comments/ideas/whatever on > what I saw: > > 1) I like the bar and tree view for the main partitioning screen. But I don't > think it's used effectively for adding new partitions. I'd like to see the > Create button disabled until you have clicked on something that would allow a > Create operation. For example, to create a regular partition on /dev/sda, I > should have to click /dev/sda in the tree or bar view to highlight that drive, > then I can click Create to add the partition. > > This should also remove the 'Allowable drives' checkbox list in the Add > Partition window. Once you've clicked the item you want to create something > on, there should be no need for the Allowable drives checkbox list. This is definitely the right direction. I think this should got in the next batch of patches though. Adding this to this patch set would disrupt it. Additionally, this suggestion starts moving in the direction of giving the user more control. If we implement the customization window in this way we would, probably, not need the allocate partition logic. Or, if we need it, we would not use it as extensively as we do now. As I said, I am 100% for this idea. > > 2) Similar to the Allowable drives removal, I would like to see the logical > volume list in the Add LVM Volume Group window go away. If I Create a volume > group, that group should then appear in the bar and tree view and I should be > able to click on it, click Create, and be offered the option to create a > logical volume. That could use the Add Partition window, with labels modified > and unnecessary fields removed. Yep, this is also something that give the user more control with allocation. My previous comment applies here as well. > > Logical volume editing works in style in the videos, so creating logical > volumes should be in a similar style. > > [And I see you already mentioned this in your initial email as something that > does not yet work.] > > 3) I would still like to give users the ability to select a display unit other > than MB in the partitioning UI. I know I've mentioned this before. I would > also like to see the values themselves have a unit indicator next to them as > opposed to just in the column header. This is something that needs to happen in storage/devices.py. ATM we have various getSize functions, some being properties that just return one type of size. A pyparted type getSize function where one defines the unit would be great. We can also create a function that returns a size string. This getSizeString function would have the additional functionality of specifying the number of characters that is needed. So, on can make a call of type `text = device.getSizeString(numchars=5)` and get something like "10 Gb". I'm just thinking out loud here. > > 4) The Edit and Delete buttons should be disabled when nothing valid is > selected for those actions. This might be a good idea to include in this patch set. I don't see it being very big. > > - -- David Cantrell <dcantrell@xxxxxxxxxx> > Red Hat / Honolulu, HI > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkqy4TwACgkQ5hsjjIy1VkkvhQCaA9y0prIywBOs88h521jERBoV > iC0AoMv3JGbMwAbd4SE+48djXYcaNsz0 > =hYun > -----END PGP SIGNATURE----- > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list -- Joel Andres Granados Brno, Czech Republic, Red Hat.
Attachment:
pgpKeINds0qQ0.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
