On Mon, Sep 21, 2009 at 03:49:44PM -0400, Chris Lumens wrote: > > @@ -597,8 +603,10 @@ def doPartitioning(storage, exclusiveDisks=None): > > bootDev.req_bootable = True > > > > # FIXME: make sure non-existent partitions have empty parents list > > - allocatePartitions(disks, partitions) > > - growPartitions(disks, partitions) > > + if alloc: > > + allocatePartitions(disks, partitions) > > + if grow: > > + growPartitions(disks, partitions) > > # The number and thus the name of partitions may have changed now, > > # allocatePartitions() takes care of this for new partitions, but not > > # for pre-existing ones, so we update the name of all partitions here > > This should probably be: > > if alloc: > allocatePartitions(disks, partitions) > > if grow: > growPartitions(disks, partitions) > > Otherwise it'd be possible to call with alloc=False, grow=True and that > just seems like asking for trouble. With the way things are right now, you are correct. Done :) > > - Chris > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list -- Joel Andres Granados Brno, Czech Republic, Red Hat.
Attachment:
pgpwuqXP5PJID.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list