Re: [PATCH 04/14] Do not use object we are creating.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Lumens wrote:
Why do we want to do this?  Now you're introducing the "/mnt/source"
constant in multiple places which means that if we do ever have to
change it, we'll forget in one of the places.

I know, the problem here is that we are calling _applyMedia (via methodstr editing dialog)
referring to ayum object from ayum's __init__ (-> traceback).

Another solution I tried was to move all the scanMedia thing from the _applyMedia
method to configBaseURL (where it belongs I think - the dialog should
only change methodstr in case of configBaseURL fail). It required
quite a lot of code to be changed that would conflict with repo editing dialog
flow in that stage of patches [4/14].

Yet another option was to pass the value to the dialog as parameter but I
didn't like it - it seemed less transparent and more ugly than using
"/mnt/source" to me, but I can do it this way.

Radek

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux