Re: [PATCH 04/14] Do not use object we are creating.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/iw/task_gui.py b/iw/task_gui.py
> index da3d2ff..2877a5c 100644
> --- a/iw/task_gui.py
> +++ b/iw/task_gui.py
> @@ -411,7 +411,7 @@ class RepoMethodstrEditor(RepoEditor):
>          return repourl
>  
>      def _applyMedia(self):
> -        cdr = scanForMedia(self.anaconda.backend.ayum.tree, self.anaconda.id.storage)
> +        cdr = scanForMedia("/mnt/source", self.anaconda.id.storage)
>          if not cdr:
>              self.intf.messageWindow(_("No Media Found"),
>                                      _("No installation media was found. "
> @@ -419,7 +419,7 @@ class RepoMethodstrEditor(RepoEditor):
>                                        "and try again."))
>              return False
>  
> -        return "cdrom://%s:%s" % (cdr, self.anaconda.backend.ayum.tree)
> +        return "cdrom://%s:%s" % (cdr, "/mnt/source")
>  
>      def _applyNfs(self):
>          server = self.nfsServerEntry.get_text()

Why do we want to do this?  Now you're introducing the "/mnt/source"
constant in multiple places which means that if we do ever have to
change it, we'll forget in one of the places.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux