Hi, Upstream pylint has finally fixed the bug with the relative imports which made it impossible to use pylint with anaconda. So after bugging the package maintainer to get the latest version in rawhide (done now) I've been running pylint on anaconda today. The result is a patch set which I will send shortly. With this patchset, pylint runs "cleanly" (as in no errors reported after false positive filtering) on the storage, iw and booty subdirs. Attached is the script I'm using, drop this in your anaconda dir together with the pylint-false-positives file to give it a try. I know some of these patches only serve to make pylint happy (while others fix real bugs) still I believe this is worth it, so that we can eventually run pylint automatically. Just look at the real bugs caught (some if which were introduced recently). Regards, Hans
^F0401:[ 0-9]*: Unable to import 'gtk.gdk'$ ^F0401:[ 0-9]*: Unable to import 'repomd.mdErrors'$ ^E1101:[ 0-9]*:.*: Class 'vbox' has no 'pack_start' member$ ^E1101:[ 0-9]*:.*: Instance of 'WideCheckList' has no 'get_model' member$ ^E1101:[ 0-9]*:.*: Instance of 'WideCheckList' has no 'get_column' member$ ^E1101:[ 0-9]*:.*: Instance of 'WideCheckList' has no 'set_expander_column' member$ ^E1101:[ 0-9]*:.*: Instance of 'WideCheckList' has no 'append_row' member$ ^E1101:[ 0-9]*:.*: Instance of 'WideCheckList' has no 'store' member$ ^E1101:[ 0-9]*:.*: Instance of 'WideCheckList' has no 'set_size_request' member$ ^E1103:[ 0-9]*:.*: Instance of 'str' has no '.*' member \(but some types could not be inferred\)$ ^E1101:[ 0-9]*:AnacondaTZMap.selectionChanged: Instance of 'Enum' has no 'ENTRY' member$ ^E0602:[ 0-9]*:sparcBootloaderInfo.writeSilo: Undefined variable 'butil'$ ^W0233:[ 0-9]*:x86BootloaderInfo.__init__: __init__ method from a non direct base class 'bootloaderInfo' is called$ ^E1101:[ 0-9]*:DeviceAction\..*: Instance of 'DeviceAction' has no 'dir' member$ ^E0601:[ 0-9]*:VolumeGroupEditor.editLogicalVolume.<lambda>: Using variable 'maintable' before assignment$ ^E1101:[ 0-9]*:VolumeGroupEditor.editLogicalVolume: Class 'format' has no 'mountable' member$ ^W0231:[ 0-9]*:DiskTreeModel.__init__: __init__ method from base class 'TreeStore' is not called$ ^E1101:[ 0-9]*:Device.packages: Instance of 'Device' has no 'format' member$ Note this last line must never end with a newline
Attachment:
runpylint.sh
Description: application/shellscript
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
