Re: [PATCH] Don't to unmount /mnt/source unless something's mounted there (#516304).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/anaconda b/anaconda
> index 705edca..c366bbe 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -488,6 +488,11 @@ class Anaconda:
>          b = instClass.getBackend()
>          self.backend = apply(b, (self,))
>  
> +    def setStage2str(self, stage2str):
> +        if stage2str.startswith("cdrom://"):
> +            self.mediaDevice = stage2str[8:].split(":")[0]
> +        self.stage2 = stage2str
> +
>      def setMethodstr(self, methodstr):
>          if methodstr.startswith("cdrom://"):
>              (device, tree) = string.split(methodstr[8:], ":", 1)

I don't like overloading mediaDevice in this way, though.  Right now if
you look through yuminstall.py and other files, you'll see that
mediaDevice refers to the CD/DVD device where the installation source is
coming from.  That is, the media that contains *packages*, not the media
that contains a bootable image.

I think if we do this, we'll end up breaking some kind of install
method, perhaps boot.iso+NFS or something similar.  I'm concerned we
will try to eject the media halfway through the installation or
something silly like that.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux