Re: [PATCH] Don't to unmount /mnt/source unless something's mounted there (#516304).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thinking a little more on the issue 0001 is not really needed as 0002
makes the "if mediaDevice" True.

Regards.
On Mon, Aug 10, 2009 at 06:18:24PM +0200, Joel Granados wrote:
> Hey list:
> 
> Wouldn't the attached patch be better?  We have the added value of doing
> all the stuff we do for the media when we have it.  Additionally, since
> we are checking that self.ayum.tree exist and is mounted, I dont think
> it should be in an elif.
> 
> Regards.
> On Mon, Aug 10, 2009 at 11:45:10AM -0400, Chris Lumens wrote:
> > ---
> >  yuminstall.py |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/yuminstall.py b/yuminstall.py
> > index 84445b0..a56fd71 100644
.
.
.
>  yuminstall.py |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/yuminstall.py b/yuminstall.py
> index 84445b0..3dbc92e 100644
> --- a/yuminstall.py
> +++ b/yuminstall.py
> @@ -1036,7 +1036,8 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon
>                                  "%s/var/cache/yum/%s" %(anaconda.rootPath, repo))
>              except Exception, e:
>                  log.debug("Error setting up media repository: %s" %(e,))
> -        else:
> +
> +        if os.path.exists(self.ayum.tree) and os.path.ismount(self.ayum.tree):
>              isys.umount(self.ayum.tree)
>  
>          anaconda.backend.removeInstallImage()
> -- 
> 1.6.0.6
> 




> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

Attachment: pgpuVfXcnTuwC.pgp
Description: PGP signature

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux