Chris Lumens wrote:
This one makes me nervous. Have you tested with all combinations of
repo=/stage2=/method= providing both correct and incorrect information,
with kickstart files, and with going through the UI? This is an
extremely complicated area of the loader and we'd made a ton of changes
here that subtly break in other ways later on.
OK, I did quite an amount of testing and the patch doesn't break
anything I tested,
but I found some other bugs:
1) Is the location of install.img set by ks or by stage2/repo/method
boot parameter?
a) no:
I tested the UI flow back and forth repatedly. The patch doesn't
break anything.
I found two bugs:
[A] set bad location in NFS dialog, error message [OK], NFS dialog
[Back], got
to kbd selection (not Install method selection), [Ok] -> traceback
(both with/without using ks). URL dialog works ok in this
scenario.
[B] if url/nfs ks is used (that is network is up), with steps:
Install method dialog, NFS/URL dialog [Back], Install method
dialog,
*Network setting dialog appears* - it shouldn't, NFS/URL dialog.
b) yes:
If the location is bad, there is another bug [C]:
dialog about bad location appears, [OK], URL/NFS dialog to change
the location,
[Back] -> traceback - either immediately or after going back to
kbd selection
and [OK] which results in the same traceback. Concerns both URL
and NFS.
For NFS, this bug has probably the same cause as [A].
Should we offer going back to change install method in such cases
when it is
specified via ks or boot options?
If the location is OK or is corrected in NFS/URL dialog,
everything works fine
both with and without the patch, be specified in ks or by
stage2/repo/method
boot option.
2) Another bug:
[D] [Back] doesn't work in Network setting dialog
I'm working on the bugs I found.
Radek
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
