Re: [PATCH 2/2] Fix going back from "Installation Method" screen in stage 1 (#515450)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/loader/loader.c b/loader/loader.c
> index 17cb918..2e3a5d0 100644
> --- a/loader/loader.c
> +++ b/loader/loader.c
> @@ -1382,7 +1382,7 @@ static char *doLoaderMain(struct loaderData_s *loaderData,
>                                       _("OK"), _("Back"), NULL);
>                  }
>  
> -                if (rc && (rc != 1) && (loaderData->method == -1)) {
> +                if (rc && (rc != 1) && (loaderData->method == -1 || !skipMethodDialog)) {
>                      loaderData->method = -1;
>                      step = STEP_KBD;
>                      dir = -1;

This one makes me nervous.  Have you tested with all combinations of
repo=/stage2=/method= providing both correct and incorrect information,
with kickstart files, and with going through the UI?  This is an
extremely complicated area of the loader and we'd made a ton of changes
here that subtly break in other ways later on.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux