[PATCH 5/5] prevent getting started up or shutdown again while already in such state

[Steffen Maier <maier@xxxxxxxxxxxxxxxxxx>]

Essential with all the correct error handling in place.
---
 storage/zfcp.py |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/storage/zfcp.py b/storage/zfcp.py
index 2584268..ea7e4f4 100644
--- a/storage/zfcp.py
+++ b/storage/zfcp.py
@@ -177,6 +177,7 @@ class ZFCP:
     def __init__(self):
         self.fcpdevs = []
         self.hasReadConfig = False
+        self.down = True
 
     def readConfig(self):
         try:
@@ -221,15 +222,23 @@ class ZFCP:
             self.fcpdevs.append(d)
 
     def shutdown(self):
+        if self.down:
+            return
+        self.down = True
         if len(self.fcpdevs) == 0:
             return
         for d in self.fcpdevs:
             d.offlineDevice()
 
     def startup(self):
+        if not self.down:
+            return
+        self.down = False
         if not self.hasReadConfig:
             self.readConfig()
             self.hasReadConfig = True
+            # readConfig calls addFCP which calls onlineDevice already
+            return
             
         if len(self.fcpdevs) == 0:
             return
-- 
1.6.3.1


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list