Re: [PATCH] Add omitted livecd flag in condition for livecd sanity check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeremy Katz wrote:
On Friday, April 03 2009, Radek Vykydal said:
diff --git a/storage/__init__.py b/storage/__init__.py
index 3d3ba15..15035ed 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -784,7 +784,8 @@ class Storage(object):
                             productName))
# livecds have to have the rootfs type match up
-        if (root and
+        if (flags.livecdInstall and
+            root and
             self.anaconda.backend.rootFsType and
             root.format.type != self.anaconda.backend.rootFsType):
             errors.append(_("Your / partition does not match the "

This shouldn't be needed -- we actually allow other backends to set a
required rootfstype too.  The error message is live-specific at the
moment, but that was mostly out of laziness and difficulty of coming up
with a generic wording
You are right, this would be bad fix for the traceback I was getting in the condition
(YumBackend instance has no attribute rootFsType), it even seems my
testing environment (updates.img, install.img) is dirty, looking into it.

Radek

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux