>> + else: >> + if devspec.startswith("/dev/"): >> + dev = devspec[5:] >> + else: >> + dev = devspec >> + >> + name = udev_device_get_name(entry) >> + if name == dev: >> + storage.protectedPartitions = [name] >> + break >> + > > This won't work for doing installs with the devspec being a logical vol. We've never supported putting the ISOs on anything besides a partition anyway, so this isn't a case I'm too worried with right now. > In that case > we need to remove /dev/mapper from the devspec to get the name. Also to me this feels a > lot like the devicePathToDeviceName() function I introduced in my (proposed) cciss > handling patch. May I suggest to commit this as is and then later replace it by > devicePathToDeviceName() ? It seems a good idea to keep all the /dev/..... -> devicetree name > code in one place. Sure, we can do that conversion later. I don't like having the /dev/ removing code scattered all over the place either. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list