Re: [PATCH 03/13] Add method to get size of existing filesystems.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/16/2009 02:03 AM, Jacek Danecki wrote:
David Cantrell wrote:
On 03/15/2009 08:57 AM, Eric Sandeen wrote:
David Lehman wrote:
On Fri, 2009-03-13 at 18:09 -1000, David Cantrell wrote:
The _getExistingSize() method in class FS will using the filesystem
info/dump utility to figure out the size of the filesystem. Each
filesystem must define _infofs, _defaultInfoOptions, and
_existingSizeFields.
Looks okay to me. This is kind of scary stuff, but I think that's just
how it is when you have to parse output like this.
Why not just do a temporary mount somewhere (if not already mounted) and
run statfs on it? Wouldn't that be simpler?</hand_wave>

It would be. Attached is a new patch. I didn't know we could call
statvfs() from Python (nor did I ever bother to look, but whatever).


I've got exception Ext3FS object has no attribute _mountpoint in
fs.py:203. This was during tests on raid 1 created by OROM for isw format.

Checking in to this.  Thanks for testing.

--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux