Jeremy Katz wrote:
On Monday, March 16 2009, Hans de Goede said:
Jeremy Katz wrote:
On Sunday, March 15 2009, David Lehman said:
Why not just do a temporary mount somewhere (if not already mounted) and
run statfs on it? Wouldn't that be simpler?</hand_wave>
It would be. Attached is a new patch. I didn't know we could call
statvfs() from Python (nor did I ever bother to look, but
whatever).
Much nicer.
Mounting can entail side effects, though, such as journal recovery and
has also in some cases ended up with filesystems having new,
incompatible features enabled. While I guess it's possible that running
dumpe2fs, etc on a filesystem could do similar things, it just feels a
lot less likely.
Another problem is this fails in the livecd case, as for example the live-usb stick
there is usually already (auto) mounted, so this fails with a busy error, leading to
a traceback.
Well, in the past, things weren't already auto-mounted. This seems to
be a new behavior with DeviceKit-disks that, thus far at least, I
haven't found a good way to turn off.
Jeremy
Ack, it even automounts fs we've just created, very annoying!
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
