Hi,
I'm thinkig about change of timezone setting in fedora,
there are two related things:
1) setting timezone during installation ("setuptime" step)
fails because we don't have /usr/share/zoneinfo tree in stage2.
(https://bugzilla.redhat.com/show_bug.cgi?id=473647)
We can either move "setuptime" step after "installpackages" step
and use just installed timezone tree, or keep the zoneinfo tree in stage2
(cca 5.5 MB). I'm for the former, it seems safe to me based on
what I saw in the code and a quick test. Patch is attached.
2) there is request (RFE) for allowing more timezone specifiers,
not only these in /usr/shar/zoneinfo/zone.tab which we use
for ks value checking (in case of failure we ask in UI).
(https://bugzilla.redhat.com/show_bug.cgi?id=461526)
I can see three ways how to have more specifiers along with
ks value checking:
- Keep zoneinfo tree in stage2 to check against.
- Check with file generated from the tree in buildinstall
(we used to have timezone.gz i think).
- Add --nocheck option to timezone ks option to prevent
check and asking in UI. If we don't find the timezone
when setting it (according to 1) in installed zoneinfo tree),
fail to set it during installation, and for installed system
use default value.
As we moved from the first two in fedora, I'd opt for the last one.
Radek
diff --git a/dispatch.py b/dispatch.py
index 3a7dc1a..db5204f 100644
--- a/dispatch.py
+++ b/dispatch.py
@@ -99,10 +99,10 @@ installSteps = [
("group-selection", ),
("postselection", doPostSelection, ),
("install", ),
- ("setuptime", setupTimezone, ),
("preinstallconfig", doPreInstall, ),
("installpackages", doInstall, ),
("postinstallconfig", doPostInstall, ),
+ ("setuptime", setupTimezone, ),
("writeconfig", writeConfiguration, ),
("firstboot", firstbootConfiguration, ),
("instbootloader", writeBootloader, ),
diff --git a/packages.py b/packages.py
index c141c92..543f4d1 100644
--- a/packages.py
+++ b/packages.py
@@ -191,7 +191,7 @@ def setupTimezone(anaconda):
return
os.environ["TZ"] = anaconda.id.timezone.tz
- tzfile = "/usr/share/zoneinfo/" + anaconda.id.timezone.tz
+ tzfile = anaconda.rootPath + "/usr/share/zoneinfo/" + anaconda.id.timezone.tz
if not os.access(tzfile, os.R_OK):
log.error("unable to set timezone")
else:
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
