Bart Van Assche wrote:
On Mon, Jan 19, 2009 at 4:35 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
- libiscsi_discover_sendtargets - maybe (very maybe) the "int port" could be dropped and
"const char *address" could be of the form "address_or_host[:port]".
Regarding defaults and all that.
Nah, that is ok for a cmdline interface, but cumbersome for an API, we could do
something where port == 0 would choose the default port though.
Have you considered to replace both "const char *address" and "int
port" by "const struct sockaddr *address, socklen_t address_len" ?
This would avoid having to figure out inside
libiscsi_discover_sendtargets() whether the passed address is in IPv4
or in IPv6 format (if numeric).
libiscsi builds on top of the existing open-iscsi userspace code, in this code
the "const char *address" and "int port" notation is used everywhere.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
