Hans de Goede wrote:
2) Do a lot more automated testing / checking
1. Has already been discussed, so lets take a look at 2. My plans for 2
are:
1) Run PyChecker and fix anaconda sources where necessary to make PyChecker
happy
2) Use python -tt, this will require whitespace fixups, but I've heard
grumblings about our inconsistent whitespace usage from various sources,
we even have bugs opened about this (which I can't find right now, but
they exist).
The only argument against doing whitespace cleanups is
that it makes porting patches between RHEL-5 and rawhide harder, well
that is usually a job which needs to be done manual anyways, and as the
code diverges more this becomes ever more true.
3) Add a "make test" target which calls PyChecker and possible does
other tests
and add "make test" as %check to the spec file.
Yes this means that having something which PyChecker does not like will
break the build, this is intentional. Its better to have an old working
build (with known bugs) in the tree for a day longer, then it is to have
a new build which
has known new issues (potentially of the will not install at all type).
Some people will probably not like this, and to be honest, I don't care.
Go clean up your act. This is just like people ignoring "gcc -Wall"
warnings, I've been a Computer Science teacher for too long and as such
have seen to much failing code where the compiler warned it was valid C
but not good C, which probably did not do what the programmer wanted,
and the compiler was right.
After being a CS teacher for 10 years I've heard every possibly excuse
to ignore whatever warnings and every single excuse was lousy!
Sorry if I sound a bit harsh here, but currently we are doing a not so
Yer soft!
I would go further, if there are problems your interpreter (Python,
Ruby, Perl, Whatever) could find/fix and doesn't lobby to have the
interpreter improved to find/fix them.
--
Cheers
John
-- spambait
1aaaaaaa@xxxxxxxxxxxxxxxx Z1aaaaaaa@xxxxxxxxxxxxxxxx
-- Advice
http://webfoot.com/advice/email.top.php
http://www.catb.org/~esr/faqs/smart-questions.html
http://support.microsoft.com/kb/555375
You cannot reply off-list:-)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
