Alexander Todorov wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Jeremy Katz wrote:
|
| I'm not entirely convinced on this front -- this then requires a lot of
| manual work to find and mount the rootfs and thus avoids testing one of
| the biggest parts of rescue mode (finding and mounting the root). We're
| probably better off doing the mount through the normal paths if you're
| doing kickstart rescue mode
|
Leaving aside the mount of the root fs we can test other stuff: FirstAidKit
Firstaidkit needs the installed system. If it does not have it, it will act differently. It actually looks for the system in /mnt/sysimage and goes from there. The reason for this is that it is rescuing the system that is mounted in /mnt/sysimage and actually needs it to do so. In this same train of though I can think of various important things to test with respect to finding the installed system.
1. To actually recognize an installed system when important stuff is missing.
2. To recognize the prefered installed system (default behavior) when the user has more than one system installed.
those are the two I can think of off the top of my head.
(although you can test it by other means also), if the rescue
environment is
sane (e.g. bash is there), if we can chroot into the system (given we've
mounted
that by hand), network setup, anything else people will do if they boot
with
nomount and start poking around in the shell.
What bothers me here is that (mounted by hand). Instead of going around the fact that anaconda askes question I would devise a way of automating answering the questions. This will provide a way to get to the rescue env, while testing whatever the questions do (like find the installed system).
I agree with doing the mount through the current code but how do we cleanly
avoid the places where the user is asked to make a decision:
Mount: Read/Write, Read only, Skip ?
Just put an:
if inRescueMode:
if noUserInput
answer = "Default"
else
answer = UserInput
What partition contains the root fs?
As a test mechanism, you should know the right answer for this. This could be handled in the same way as the question answering.
Any assumption to answers of these questions will be generally wrong and
Ok, I totally missed something here. If you are testing you should know the answers for this. no? If you don't how would you be sure that a given behavior is correct or incorrect. like when I anser yes and it mounts the wrong disk?
will
break on different systems. The only possible way I see is to add
additional
command{s} to kickstart which answer them. E.g.
In the case of a single command:
parttomount --dev /dev/sda1 --mode r --fstype ext3 --path /mnt/sysimage
Yep, but this is just going around the autodetecting functionality. This could be easily done by answering "no" in the "do you want to mount previous system" question. And them mounting everything in the post section. Additionally it avoids adding more stuff to pykickstart. (less is more)
I'm OK with adding this to kickstart but wanted to see what others think.
Im not saying don't add to kickstart. Im just don't add too much. And I think adding a line where you specify partition stuff is not good. I would much rather add a `mount /dev/sda1 /mnt/sysimage` in the post section.
Thanks,
Alexander.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org
iD8DBQFIhzJfhmd3WOiFct4RCk7yAJ9CM9RbPlvTk8dSlCPALFcDcMZeNgCfT6TM
pwbH+SWiwiewaAmXAl0BfHk=
=6Ggg
-----END PGP SIGNATURE-----
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
Joel Andres Granados
Red Hat / Brno, Czech Republic
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
