Hi,
I found a keyboard binding bug.
At "Add Partition" window, it's "Additional Size Options" table(frame).
-- Additional Size Options -------
| ( ) Fixed size
| ( ) Fill all space up to (MB): [ gtk.SpinButton ]
| ( ) Fill to maximum allowable size
---
When we operate that table with keyboard(Up/Down arrow key),
The focus order is as follows.
> 1. Fixed size
> 3. Fill all space up to (MB): [ gtk.SpinButton ]
> 2. Fill to maximum allowable size
It's strange for users intuitively.
This bug is creating gtk.HBox() container for second radio and spin buttons.
It seems the GTK recognize another layer(or focus order) to pack radio and spin buttons.
If its purpose is just for layout,
we can specify the layout which is attached for gtk.Table().
# refer to attachment patch
# I confirmed my patch works the intended operation for Fedora9 with anaconda-11.4.0.82-1
Could you review my patch, please ?
and I'd appreciate it if you could give me the comment.
thanks,
Tetsuya MORIMOTO
diff --git a/iw/partition_dialog_gui.py b/iw/partition_dialog_gui.py
index 0b5e52d..2788998 100644
--- a/iw/partition_dialog_gui.py
+++ b/iw/partition_dialog_gui.py
@@ -76,9 +76,6 @@ class PartitionEditor:
upper = MAX_PART_SIZE, step_incr = 1)
fillmaxszsb = gtk.SpinButton(maxsizeAdj, digits = 0)
fillmaxszsb.set_property('numeric', True)
- fillmaxszhbox = gtk.HBox()
- fillmaxszhbox.pack_start(fillmaxszrb)
- fillmaxszhbox.pack_start(fillmaxszsb)
fillunlimrb = gtk.RadioButton(group=fixedrb,
label=_("Fill to maximum _allowable "
"size"))
@@ -98,7 +95,8 @@ class PartitionEditor:
fixedrb.set_active(1)
sizeoptiontable.attach(fixedrb, 0, 1, 0, 1)
- sizeoptiontable.attach(fillmaxszhbox, 0, 1, 1, 2)
+ sizeoptiontable.attach(fillmaxszrb, 0, 1, 1, 2)
+ sizeoptiontable.attach(fillmaxszsb, 1, 2, 1, 2)
sizeoptiontable.attach(fillunlimrb, 0, 1, 2, 3)
frame.add(sizeoptiontable)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
