Thanks for the patch. Will test it out and apply to rawhide.
On Wed, 2007-05-02 at 10:29 +0800, Dawei Pang wrote:
> Hi,
> I found 'loader received SIGSEGV' when I configure network in the
> 'Manual TCP/IP Configuration'.
> The problem happened on the 64bit arch first and maybe lead some wrong
> check for netmask in the other arch.
> After I traced the code, I found that the SIGSEGV happen in the
> cidrCallback function.
> The point address of data->cidr4Entry,data->cidr6Entry is wrong.
> I found that the code of net.c have some point error, the patch as
> followed may fix the problem.
> Please check,thank you very much.
> ------------------------------------------------------------------------------------------------
> diff -Nura 0501/loader2/net.c 0501.new/loader2/net.c
> --- 0501/loader2/net.c 2007-04-28 03:53:15.000000000 +0800
> +++ 0501.new/loader2/net.c 2007-05-02 00:11:38.000000000 +0800
> @@ -933,8 +933,8 @@
> newtGridSetField(egrid, 1, pos, NEWT_GRID_SUBGRID, qgrid,
> 0, 0, 0, 0, NEWT_ANCHOR_LEFT, 0);
>
> - newtComponentAddCallback(ipcomps->ipv4Entry, ipCallback, &ipcomps);
> - newtComponentAddCallback(ipcomps->cidr4Entry, cidrCallback, &ipcomps);
> + newtComponentAddCallback(ipcomps->ipv4Entry, ipCallback, ipcomps);
> + newtComponentAddCallback(ipcomps->cidr4Entry, cidrCallback, ipcomps);
>
> /* populate fields if we have data already */
> tip = NULL;
> @@ -985,8 +985,8 @@
> newtGridSetField(egrid, 1, pos, NEWT_GRID_SUBGRID, rgrid,
> 0, 0, 0, 0, NEWT_ANCHOR_LEFT, 0);
>
> - newtComponentAddCallback(ipcomps->ipv6Entry, ipCallback, &ipcomps);
> - newtComponentAddCallback(ipcomps->cidr6Entry, cidrCallback, &ipcomps);
> + newtComponentAddCallback(ipcomps->ipv6Entry, ipCallback, ipcomps);
> + newtComponentAddCallback(ipcomps->cidr6Entry, cidrCallback, ipcomps);
>
> /* populate fields if we have data already */
> tip = NULL;
> @@ -1053,8 +1053,8 @@
> newtEntrySet(ipcomps->nsEntry, ret, 1);
> }
>
> - newtComponentAddCallback(ipcomps->gwEntry, ipCallback, &ipcomps);
> - newtComponentAddCallback(ipcomps->nsEntry, ipCallback, &ipcomps);
> + newtComponentAddCallback(ipcomps->gwEntry, ipCallback, ipcomps);
> + newtComponentAddCallback(ipcomps->nsEntry, ipCallback, ipcomps);
>
> /* button bar at the bottom of the window */
> buttons = newtButtonBar(_("OK"), &okay, _("Back"), &back, NULL);
>
>
>
>
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Westford, MA
Attachment:
signature.asc
Description: This is a digitally signed message part
