Re: handleKernelModule patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 09, 2006 at 06:27:56PM +0000, andre.maidl@xxxxxxxxxxxx wrote:
> Date: Tue, 9 May 2006 15:27:56 -0300
> From: Andre Murbach Maidl <andre.maidl@xxxxxxxxxxxx>
> To: anaconda-devel-list@xxxxxxxxxx
> Subject: handleKernelModule patch
> Message-ID: <20060509182756.GA4292@xxxxxxxxxxxxxxxxxxxxx>
> Mime-Version: 1.0
> Content-Type: multipart/mixed; boundary="ZGiS0Q5IWpPtfppv"
> Content-Disposition: inline
> User-Agent: Mutt/1.4.2.1i
> 
> 
> --ZGiS0Q5IWpPtfppv
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> 
> Hi folks,
> 
> We are trying to create a Fedora Core 5 customized distro.
> But, when we added a package called kernel-module-ntfs
> anaconda broke because it couldn't solve the dependencies.
> 
> I looked for it and found that it was happening because
> the function handleKernelModule was missing.
> 
> This function was in depsolve.py, in early versions, but this
> file was removed from the anaconda-11.1.0.4.
> 
> At some point in yuminstall.py we have some functions
> taken from depsolve.py, but handleKernelModule wasn't
> there. I fix the problem adding the function in
> yuminstall.py with the other functions from depsolve.py.

Well, at this point kernel module support isn't supposed to be in Yum
propper.  Current CVS of anaconda shows that call commented out (line
562).  And that's the correct answer here, anaconda should not be
calling that function.  In fact, Jeremy, see attached.

With what may be a new job and RHEL 5 looking like it will be completely
Yum based I'll have a lot more time/ability to sit down and work on that
plugin so it doesn't suck. 

Jeremy, how are you planning to handle Yum plugins in Anaconda?

Jack

-- 
Jack Neely <jjneely@xxxxxxxx>
Campus Linux Services Project Lead
PAMS Computer Operations at NC State University
GPG Fingerprint: 1917 5AC1 E828 9337 7AA4  EA6B 213B 765F 3B6A 5B89
? kmod.patch
Index: yuminstall.py
===================================================================
RCS file: /usr/local/CVS/anaconda/yuminstall.py,v
retrieving revision 1.169
diff -u -r1.169 yuminstall.py
--- yuminstall.py	9 May 2006 18:59:28 -0000	1.169
+++ yuminstall.py	11 May 2006 18:27:50 -0000
@@ -559,9 +559,6 @@
                 rpmfile = txmbr.po.localPkg()
                 
                 if txmbr.ts_state == 'u':
-                    # XXX: kernel-module-* support not in yum
-                    #if txmbr.po.name.startswith("kernel-module-"):
-                    #    self.handleKernelModule(txmbr)
                     if self.allowedMultipleInstalls(txmbr.po):
                         self.log(5, '%s converted to install' % (txmbr.po))
                         txmbr.ts_state = 'i'

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux