On Fri, Sep 30, 2016 at 12:50 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Thu, Sep 29, 2016 at 10:53:55PM +0200, Miklos Szeredi wrote: > >> The EFAULT logic seems to be missing across the board. And callers >> don't expect a zero return value. Most will loop indefinitely. > > Nope. copy_page_to_iter() *never* returns -EFAULT. Including the iovec > one - check copy_page_to_iter_iovec(). Any caller that does not expect > a zero return value from that primitive is a bug, triggerable as soon as > you feed it an iovec with NULL ->iov_base. Right. I was actually looking at iov_iter_get_pages() callers... Thanks, Miklos _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
