On Tue, Sep 06, 2016 at 09:26:51AM -0700, Darrick J. Wong wrote: > Yeah, at the time I thought I was going to write out a clever resolution to the > conflict between swap and CoW by using swap_activate to punch and fallocate all > the shared extents and turn off the inode reflink flag which would then enable > me to drop this patch altogether, but then got busy and forgot all about it. > Clearly I didn't fix the changelog here either. :( I looked at that, but that code is such a mess, doing reads through ->readpage and writes using direct_IO and requiring all kinds of ropes to jump through.. > "Have xfs_vm_bmap return zero for reflinked files because the bmap-based > swap code requires static block mappings, which is incompatible with > copy on write." Sounds fine. Might be worth addings something like: "And existing userspace bmap users such as lilo will have the same problems". _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs