On Mon, Aug 22, 2016 at 11:18:12AM +1000, Dave Chinner wrote: > On Tue, Aug 16, 2016 at 09:16:37AM -0500, Bill O'Donnell wrote: > > The kernel commit to make the ioctl promotion (334e580a6f) moved > > the definitions for the XFS ioctl to uapi/linux/fs.h for the > > following reason: > > > > Hoist the ioctl definitions for the XFS_IOC_FS[SG]SETXATTR API > > from fs/xfs/libxfs/xfs_fs.h to include/uapi/linux/fs.h so that > > the ioctls can be used by all filesystems, not just XFS. This > > enables (initially) ext4 to use the ioctl to set project IDs on > > inodes. > > > > This means we now need to handle this change in userspace as the > > uapi/linux/fs.h file may not contain the definitions (i.e. new > > xfsprogs/ old linux uapi files) xfsprogs needs to build. Hence we > > need to massage the definition in xfs_fs.h to take the values from > > the system header if it exists, otherwise keep the old definitions > > for compatibility and platforms other than linux.. > > > > This patch was originally submitted by Dave Chinner > > (http://oss.sgi.com/archives/xfs/2016-02/msg00108.html) > > > > Resubmitting with changes to accomodate upstream changes since > > initial submission. > > This is unnecessary - the "include local version" changes were made > to the platform headers (e.g. include/linux.h) in commit 83f4b5a > ("xfs_fs.h: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR > promotion"). Sorry, I missed that. I'll remove this patch on v3. Thanks- Bill > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
