On Tue, Aug 16, 2016 at 09:16:36AM -0500, Bill O'Donnell wrote: > This allows xfs_quota to be used on ext4 for project quota testing > in xfstests. > > This patch was originally submitted by Dave Chinner > (http://oss.sgi.com/archives/xfs/2016-02/msg00131.html) > > Resubmitting with the following change: > quota/init.c: correct logic error in loop contained in init_args_command() > function (lines 85-91). What logic error? Commit messages like this really don't tell the reader anything about what is different the original patch. I've had to go archive spelunking to work out what is different, and I'm still not sure what the logic error you fixed is.... And, FWIW, whilst spelunking, I noticed that Eric's last review comments on my original patch: Looks ok, but now with the new option: 1) needs a manpage update 2) usage() should be updated to include -f 3) and I just noticed, _("foreign mount active, %s command is for XFS filesystems only\n"), seems kind of unclear; maybe just _("%s command is for XFS filesystems only\n"), have not been addressed by this update. Can you please add these these changes, update the commit message and resubmit? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
