On Thu, Aug 11, 2016 at 10:10:23AM -0700, Christoph Hellwig wrote: > This patch drops the XFS-own i_iolock and uses the VFS i_rwsem which > recently replaced i_mutex instead. This means we only have to take > one looks instead of two in many fast path operations, and we can > also shrink the xfs_inode structure. Thanks to the xfs_ilock family > there is very little churn as well. > > There is one major issue with this change though: lockdep currently > doesn't have a facility to assert a rw_sempahore is held exclusively, > which means we lose the nice ability to assert locking context in > XFS. > > Peter, I think you mentioned this would be fairly easy to add to > lockdep and the rw_semaphore code. Any chance to come up with a proof > of concept? I saw prototype patches with a writer field in the rswem to track who holds it for optimisitic spinning support. I was waiting for that to land before completely removing the mrlock abstraction from the XFS code, then changing the iolock to use the VFS inode. Regardless, if the rwsem code can be made to check for exclusive or shared locking, we can get rid of the mrlock abstraction. Can we do that first, Christoph, then make this lock change? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
