Thanks for reviewing the patch series! > Does this also error out for libraries that don't support large > off_t at all? I think that would be helpful to add if not there yet. I do not quite understand. Do you refer to libraries using libxfs or the external libraries used by xfsprogs? For the latter, none of them exports interfaces using off_t. libblkid has its own blkid_loff_t, which is defined as int64_t. For the former, patch 13 forces any user of libxfs to enable transparent LFS, by for example adding AC_SYS_LARGEFILE. The approach of libblkid is the same as what I was suggesting in a previous patch, but maybe it is good to break applications using libxfs and not transparent LFS. For example this seems to be the case for ceph. It has not enabled transparent LFS but mixes off_t and off64_t. So it is likely that it has some LFS related runtime bugs on 32bit systems. If the xfs header included the off_t size check, building ceph on 32bit systems would lead to a less subtle compile failure. Felix _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
