On Thu, Jul 07, 2016 at 07:02:32AM -0400, Benjamin Coddington wrote: > Instead of creeping pnfs layout configuration into filesystems, move the > definition of block-based export operations under a more abstract > configuration. > > Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx> > --- > fs/Kconfig | 3 +++ > fs/nfsd/Kconfig | 2 ++ > fs/xfs/Makefile | 3 +-- > fs/xfs/xfs_export.c | 2 +- > fs/xfs/xfs_pnfs.h | 4 ++-- > 5 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/fs/Kconfig b/fs/Kconfig > index 6725f59c18e6..6e57b4237d72 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -66,6 +66,9 @@ config FS_POSIX_ACL > config EXPORTFS > tristate > > +config BLOCK_EXPORT_OPS > + bool > + default n, help text? Also, BLOCK_* prefix config options are for block layer functionality, hence I suspect this will confuse people because it's a filesystem config option. EXPORTFS_BLOCK_OPS seems more obvious and correct to me, as the block mapping ops are part of the exportfs operations interface.... > xfs-$(CONFIG_SYSCTL) += xfs_sysctl.o > xfs-$(CONFIG_COMPAT) += xfs_ioctl32.o > -xfs-$(CONFIG_NFSD_BLOCKLAYOUT) += xfs_pnfs.o > -xfs-$(CONFIG_NFSD_SCSILAYOUT) += xfs_pnfs.o > +xfs-$(CONFIG_BLOCK_EXPORT_OPS) += xfs_pnfs.o Why do we need the first patch to XFS anymore? Just convert it straight to using CONFIG_EXPORTFS_BLOCK_OPS.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
