On 6 Jul 2016, at 5:19, Dave Chinner wrote:
On Tue, Jul 05, 2016 at 09:48:47PM -0400, Benjamin Coddington wrote:
We shouldn't have to configure both NFSD_BLOCKLAYOUT and
NFSD_SCSILAYOUT if
all we want are SCSI layouts on the server, so define the xfs export
operations for either configuration.
Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx>
I don't really like exploding config option dependencies into
subsystems that aren't actually related to the config options.
It's confusing enough laready that we've got XFS code dependent on
PNFSD config options without adding more to it. Instead, I'd
suggest this should be resolved in the kconfig files. i.e. make
CONFIG_NFSD_SCSILAYOUT=y select CONFIG_NFSD_BLOCKLAYOUT to resolve
the config dependency at config time.
But the point is to leave CONFIG_NFSD_BLOCKLAYOUT undefined otherwise
knfsd
will advertise block layouts to clients -- which we don't want.
Would a third define specific for xfs_export_operations that gets
set in kconfig files work for you? Something like XFS_PNFS_EXPORT_OPS.
Ben
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
