On Fri, Jun 24, 2016 at 01:39:20PM +0800, Hou Tao wrote: > remove the usage of rblocklen at xfs_bmdr_to_bmbt, and > use be16_to_cpu(dblock->bb_numrecs) instead. It also > reduces an extra calculation. What problem does this fix, why does it need to be made and how did you test it? We have to be really careful about changing code that interacts with the on-disk format, as any bugs we introduced will result in filesystem corruption. Hence you need to explain to the reviewers why the change needs to be made to the reviewers... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs