On Thu, Jun 23, 2016 at 05:46:38PM -0700, Darrick J. Wong wrote: > On Fri, Jun 24, 2016 at 10:40:22AM +1000, Dave Chinner wrote: > > On Thu, Jun 16, 2016 at 06:31:35PM -0700, Darrick J. Wong wrote: > > > Add some list operations that the deferred rmap code requires. > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > This has all come from the linux kernel, right? > > Yes. > > > Can you tell me > > which files it has come from so I can add it to the commit message? > > lib/list_sort.c for all the list_sort stuff, > include/linux/list.h for the rest of the list_* stuff, > include/linux/kernel.h for container_of. I thought we already had container_of. Ah, only inside __KERNEL__ code fragments.... > > Maybe it would be better to keep the list sorting code in it's own > > file (e.g. libxfs/list_sort.c) just to keep a bit of separation > > between the xfs code and code that is copied in from outside? > > I'd wondered if it made more sense to do that, but (sort of arbitrarily > decided not to add more files). keeping it in a spearate file makes it easier to update in future (e.g. forklift replacement of radix tree code). maybe we don't need to do this here, but I don't mind adding new files for stuff like this... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
