On Sat, Jun 18, 2016 at 04:52:38PM +0200, Felix Janda wrote: > The off64_t type is usually only conditionally exposed under the > feature test macro _LARGEFILE64_SOURCE (also defined by _GNU_SOURCE). > To make the public xfs headers more standalone therefore off64_t should > be avoided. "more standalone"? What does that mean? And what does it mean for all the xfsprogs code that still uses off64_t? i.e. if you are going to make xfsprogs fail to compile on configs that don't define off64_t, then it makes no sense to leave all the users of off64_t in the xfsprogs code.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs